Skip to content

Conversation

topepo
Copy link
Member

@topepo topepo commented Aug 25, 2023

The just-released version of rsamples has the preferred interface for validation sets.

We can't merge this until the issue with #367 are resolved in recipes

@topepo topepo marked this pull request as ready for review September 5, 2023 21:51
@topepo topepo requested a review from juliasilge September 5, 2023 21:51
Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to Ch 16 really show how nice the new interface is! 🎉

@juliasilge
Copy link
Member

GH actions built ✅ so I am merging now!

@juliasilge juliasilge merged commit 6e8b6a9 into main Sep 6, 2023
@juliasilge juliasilge deleted the new-val-sets branch September 6, 2023 19:57
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants